fix settings obs_names/var_names (closes #112) #116
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 67.30% 68.69% +1.38%
==========================================
Files 12 12
Lines 1918 1907 -11
==========================================
+ Hits 1291 1310 +19
+ Misses 627 597 -30
🚀 New features to boost your workflow:
|
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
Continue to believe that wrapping this 1-based indexing (i.e., 0 indicates missing) in a method would be helpful. Seems like just adding a method in https://mudata.readthedocs.io/stable/api/generated/mudata.MuData.html#mudata.MuData.obsmap would do it, no?
ilia-kats
force-pushed
the
fix_set_names
branch
from
9dc2848 to
5fcdf8b
Compare
|
I'm still not sure what the best approach for that would be. You could convert the zeros to NAs and subtract 1 from the rest on the fly, but that adds quite some overhead if you only need a small subset of the map. I could add a method to just get the indices given an index (be it mask or integer), so essentially just moving |
2 participants
No description provided.